Skip to content

Conversation

zihan0822
Copy link
Contributor

@zihan0822 zihan0822 commented Oct 4, 2025

Fixes #15805

ICE bisects to 9457d64, which handles the span incorrectly when part of the path originates from internal declarative macro.

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me aside from a small thing. I like that this simplifies the suggestion code a fair bit too

View changes since this review

@zihan0822 zihan0822 force-pushed the fix-legacy-numeric-constant-ice branch from 5b99d9f to 0ba022a Compare October 6, 2025 13:28
@zihan0822 zihan0822 requested a review from y21 October 6, 2025 13:38
@y21 y21 added this pull request to the merge queue Oct 7, 2025
Merged via the queue into rust-lang:master with commit c1f6124 Oct 7, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE when generating diagnostic replacement from max_value() to MAX
3 participants